[GitHub] [incubator-iceberg] rdsr commented on issue #734: HIVE: On alter table prevent hive from recursively scanning the complete table dir

[GitBox]

rdsr commented on issue #734: HIVE: On alter table prevent hive from 
recursively scanning the complete table dir
URL: https://github.com/apache/incubator-iceberg/pull/734#issuecomment-574300807
 
 
   Seems like a recursive call
   ```
   /**
      * @param table
      * @return array of FileStatus objects corresponding to the files making 
up the passed
      * unpartitioned table
      */
     public FileStatus[] getFileStatusesForUnpartitionedTable(Database db, 
Table table)
         throws MetaException {
       startWarehouseFunction("getFileStatusesForUnpartitionedTable", ": db=" + 
db.getName() + " : table=" + table.getTableName());
       Path tablePath = getTablePath(db, table.getTableName());
       try {
         FileSystem fileSys = tablePath.getFileSystem(conf);
         return HiveStatsUtils.getFileStatusRecurse(tablePath, -1, fileSys);
       } catch (IOException ioe) {
         MetaStoreUtils.logAndThrowMetaException(ioe);
       } finally {
         endWarehouseFunction("getFileStatusesForUnpartitionedTable");
       }
       return null;
     }```
   
   But I'm in favor of this PR as we'll fix the Metastore bug ourselves if 
performance is a penalty for us.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org