rdblue commented on a change in pull request #735: Refactor FilteredManifest
and ManifestGroup
URL: https://github.com/apache/incubator-iceberg/pull/735#discussion_r368158161
##########
File path: core/src/main/java/org/apache/iceberg/FilteredManifest.java
##########
@@ -95,60 +95,31 @@ public FilteredManifest caseSensitive(boolean
isCaseSensitive) {
Evaluator evaluator = evaluator();
InclusiveMetricsEvaluator metricsEvaluator = metricsEvaluator();
- return CloseableIterable.filter(reader.entries(projection(fileSchema,
columns, caseSensitive)),
+ // ensure stats columns are present for metrics evaluation
+ Collection<String> projectColumns = withStatsColumns(columns);
Review comment:
This is good, but can we make sure there is a row filter before adding these
columns? Without the row filter they aren't needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
