rdblue commented on a change in pull request #743: [spark-3] Bump Apache spark
to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r370274234
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchWrite.java
##########
@@ -493,6 +494,9 @@ protected void setCurrentKey(PartitionKey currentKey) {
public void write(InternalRow row) throws IOException {
writeInternal(row);
}
+
+ @Override
+ public void close() {}
Review comment:
Can you add a comment to explain why this is empty? If I understand
correctly, close is called after `abort` or `commit` is called. Both `abort`
and `commit` will close the current data file so there is no more cleanup to do
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
