prodeezy commented on a change in pull request #695: Cherrypick snapshot feature
URL: https://github.com/apache/incubator-iceberg/pull/695#discussion_r370295021
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -589,4 +603,20 @@ private static PartitionSpec freshSpec(int specId, Schema
schema, PartitionSpec
}
return builder.build();
}
+
+ private static String publishedWapId(Snapshot snapshot) {
Review comment:
Sorry if i misunderstood how you wanted this changed... but from what I am
trying to do.. I would like to check if a wap snapshot was published with O(1)
while keeping the Util class stateless.. This to me requires the state to be
maintained in TableMetadata but ensure the public helper method is in `WapUtil`
.. do you agree?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
