vrozov commented on a change in pull request #784: Allow caller to construct
HadoopInputFile and HadoopOutputFile using an existing instance of FileSystem
object.
URL: https://github.com/apache/incubator-iceberg/pull/784#discussion_r378004624
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopInputFile.java
##########
@@ -133,7 +143,7 @@ public SeekableInputStream newStream() {
}
public Configuration getConf() {
- return conf;
+ return fs.getConf();
Review comment:
I don't see much difference between
```
Configuration conf = new Configuration();
Path path = new Path(...);
HadoopInputFile file = HadoopInputFile.fromPath(path, conf);
...
conf = new Configuration();
file.setConf(conf);
```
and
```
Configuration conf = new Configuration();
Path path = new Path(...);
HadoopInputFile file = HadoopInputFile.fromPath(path, conf);
...
conf.set();
```
if I correctly understand your concern with incorrectly updating the
configuration. It would be necessary to copy passed configuration object to
prevent hijacking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
