shardulm94 commented on a change in pull request #778: ORC: Implement TestGenericData and fix reader and writer issues URL: https://github.com/apache/incubator-iceberg/pull/778#discussion_r378501690
########## File path: data/src/main/java/org/apache/iceberg/data/orc/GenericOrcReader.java ########## @@ -284,9 +370,9 @@ public BigDecimal convert(ColumnVector vector, int row) { final int length = (int) vector.lengths[row]; // serialize the keys Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org