rdsr commented on a change in pull request #786: replace SparkDataFile with DataFile URL: https://github.com/apache/incubator-iceberg/pull/786#discussion_r379925255
########## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ########## @@ -329,70 +222,74 @@ object SparkTableUtil { private def listAvroPartition( partitionPath: Map[String, String], partitionUri: String, - conf: Configuration): Seq[SparkDataFile] = { + spec: PartitionSpec, + conf: Configuration): Seq[DataFile] = { val partition = new Path(partitionUri) val fs = partition.getFileSystem(conf) fs.listStatus(partition, HiddenPathFilter).filter(_.isFile).map { stat => - SparkDataFile( - stat.getPath.toString, - partitionPath, "avro", stat.getLen, - stat.getBlockSize, - -1, - null, - null, - null, - null, - null) + val metrics = new Metrics(-1L, arrayToMap(null), arrayToMap(null), arrayToMap(null)) Review comment: Shouldn't `rowCount` be a positive number? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org