mehtaashish23 commented on issue #802: Update RemoveSnapshots to protect cherry-picked data files URL: https://github.com/apache/incubator-iceberg/pull/802#issuecomment-588885590 @rdblue Here is the PR on top of your branch, to add UTs, and confirms the expected behavior of this code. https://github.com/rdblue/iceberg/pull/1/files Considering that we are in conflict with latest master and also one of the newly written UT in above PR fails (as we haven't picked a fix from latest master), I have raised another PR https://github.com/apache/incubator-iceberg/pull/814 which is rebased + your changes + UTs + Marking `expireSnapshotId` as Deprecated. Feel free to follow, whatever is simple.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
