rdblue commented on a change in pull request #841: Upgrade Hive to 2.3.6 for
Iceberg
URL: https://github.com/apache/incubator-iceberg/pull/841#discussion_r392333374
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -175,7 +190,12 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
EnvironmentContext envContext = new EnvironmentContext(
ImmutableMap.of(StatsSetupConst.DO_NOT_UPDATE_STATS,
StatsSetupConst.TRUE)
);
- client.alter_table(database, tableName, tbl, envContext);
+
+ try {
+ alterTableMethod.invoke(client, database, tableName, tbl,
envContext);
+ } catch (Exception e) {
+ throw new RuntimeMetaException(e, "Failed to alter table for
%s.%s", database, tableName);
+ }
Review comment:
If you use `DynMethods` then you'd call the method like this:
```java
try {
clients.run(client -> ALTER_TABLE.invoke(client, database, tableName,
tbl, envContext));
} catch (TException e) {
throw new RuntimeMetaException(e, "Failed to alter table");
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new RuntimeException("Interrupted in call to alterTable", e);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
