rdblue commented on a change in pull request #856: [WIP] Flink Iceberg sink URL: https://github.com/apache/incubator-iceberg/pull/856#discussion_r396798607
########## File path: versions.props ########## @@ -12,6 +12,9 @@ org.apache.commons:commons-lang3 = 3.9 com.fasterxml.jackson.*:* = 2.10.0 com.github.ben-manes.caffeine:caffeine = 2.7.0 org.apache.arrow:arrow-vector = 0.14.1 +org.apache.flink:* = 1.10.0 +com.netflix.spectator:* = 0.103.0 +com.amazonaws:aws-java-sdk-s3 = 1.11.738 Review comment: Why does this include a direct dependency on the AWS SDK? File operations should go through a table's `FileIO` instance. That is `Serializable` and can be sent to writer tasks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
