rdblue commented on a change in pull request #843: [WIP] InputFormat support
for Iceberg
URL: https://github.com/apache/incubator-iceberg/pull/843#discussion_r397394482
##########
File path: build.gradle
##########
@@ -219,6 +219,58 @@ project(':iceberg-hive') {
}
}
+project(':iceberg-mr') {
+ dependencies {
+ compile project(':iceberg-api')
+ compile project(':iceberg-core')
+ compile project(':iceberg-orc')
+ compile project(':iceberg-parquet')
+ compile project(':iceberg-data')
+
+ compileOnly("org.apache.hadoop:hadoop-client") {
+ exclude group: 'org.apache.avro', module: 'avro'
+ }
+
+ testCompile project(':iceberg-hive')
+ testCompile project(path: ':iceberg-data', configuration: 'testArtifacts')
+ testCompile project(path: ':iceberg-hive', configuration: 'testArtifacts')
+ testCompile project(path: ':iceberg-api', configuration: 'testArtifacts')
+ testCompile project(path: ':iceberg-core', configuration: 'testArtifacts')
+
+ // By default, hive-exec is a fat/uber jar and it exports a guava library
+ // that's really old. We use the core classifier to be able to override
our guava
+ // version. Luckily, hive-exec seems to work okay so far with this version
of guava
+ // See: https://github.com/apache/hive/blob/master/ql/pom.xml#L911 for
more context.
+ testCompile("org.apache.hive:hive-exec::core") {
Review comment:
What about putting the test case for HiveCatalog in iceberg-hive using the
catalog function? Then we get a test that uses the catalog plugin system and we
don't have to include Hive here. Instead of having this rely on iceberg-hive,
have iceberg-hive depend on iceberg-mr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
