cmathiesen commented on a change in pull request #678: Add Java code examples
and update site docs
URL: https://github.com/apache/incubator-iceberg/pull/678#discussion_r399207986
##########
File path: build.gradle
##########
@@ -150,6 +150,16 @@ project(':iceberg-data') {
}
}
+project(':examples') {
Review comment:
It is a very good point that dependency problems can become an issue if we
collect all examples in one module.
I've fixed all the other issues pointed out in the review and I can move
tests around too if that's decided as the better approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
