sudssf commented on a change in pull request #882: fix: Failed to get status
issue because of s3 eventual consistency
URL: https://github.com/apache/incubator-iceberg/pull/882#discussion_r401939976
##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java
##########
@@ -114,6 +115,7 @@
long tableTargetFileSize = PropertyUtil.propertyAsLong(
table.properties(), WRITE_TARGET_FILE_SIZE_BYTES,
WRITE_TARGET_FILE_SIZE_BYTES_DEFAULT);
this.targetFileSize = options.getLong("target-file-size-bytes",
tableTargetFileSize);
+ this.useWriterLengthAsFileSize =
options.getBoolean("use-writer-length-as-file-size", false);
Review comment:
@rdblue do you suggestion always using writer length, instead of calling
`dataFileBuilder.withEncryptedOutputFile(currentFile)` which internally calls
getStatus for s3a?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
