jerryshao commented on a change in pull request #796: Support Spark Structured 
Streaming Read for Iceberg
URL: https://github.com/apache/incubator-iceberg/pull/796#discussion_r402168201
 
 

 ##########
 File path: spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
 ##########
 @@ -119,9 +120,18 @@
     }
 
     // look for split behavior overrides in options
-    this.splitSize = 
options.get("split-size").map(Long::parseLong).orElse(null);
-    this.splitLookback = 
options.get("lookback").map(Integer::parseInt).orElse(null);
-    this.splitOpenFileCost = 
options.get("file-open-cost").map(Long::parseLong).orElse(null);
+    this.splitSize = options.get("split-size").map(Long::parseLong).orElse(
+        Optional.ofNullable(table.properties().get(TableProperties.SPLIT_SIZE))
 
 Review comment:
   Sure, will change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to