prodeezy commented on a change in pull request #885: Add file_type to DataFile
to support deletion file
URL: https://github.com/apache/incubator-iceberg/pull/885#discussion_r404399830
##########
File path: core/src/main/java/org/apache/iceberg/GenericDataFile.java
##########
@@ -160,6 +161,14 @@ public GenericDataFile(org.apache.avro.Schema avroSchema)
{
this.keyMetadata = ByteBuffers.toByteArray(keyMetadata);
}
+ GenericDataFile(String filePath, FileFormat format, PartitionData partition,
+ long fileSizeInBytes, Metrics metrics,
+ ByteBuffer keyMetadata, List<Long> splitOffsets, Integer
fileType) {
+ this(filePath, format, partition, fileSizeInBytes, metrics, splitOffsets);
Review comment:
this can be ..
```
this(filePath, format, partition, fileSizeInBytes, metrics, keyMetadata,
splitOffsets);
this.fileType = fileType;
```
.. for better reuse of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
