rdblue commented on a change in pull request #828: iceberg-spark changes for
vectorized reads
URL: https://github.com/apache/incubator-iceberg/pull/828#discussion_r410510017
##########
File path:
spark/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java
##########
@@ -92,15 +93,24 @@ protected void cleanupFiles() throws IOException {
}
}
- protected void setupSpark() {
- spark = SparkSession.builder()
- .config("spark.ui.enabled", false)
- .master("local")
- .getOrCreate();
+ protected void setupSpark(boolean enableDictionaryEncoding) {
+ SparkSession.Builder builder = SparkSession.builder()
+ .config("spark.ui.enabled", false);
Review comment:
Does this make Spark start faster? Should we use it in other tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
