Neuw84 commented on code in PR #7988:
URL: https://github.com/apache/iceberg/pull/7988#discussion_r1262111945
##########
hive3/src/main/java/org/apache/iceberg/mr/hive/vector/CompatibilityHiveVectorUtils.java:
##########
@@ -67,10 +66,10 @@ public static MapWork findMapWork(JobConf job) {
LOG.debug("Initializing for input {}", inputName);
}
String prefixes = job.get(DagUtils.TEZ_MERGE_WORK_FILE_PREFIXES);
- if (prefixes != null && !StringUtils.isBlank(prefixes)) {
- // Currently SMB is broken, so we cannot check if it's compatible with
IO elevator.
- // So, we don't use the below code that would get the correct MapWork.
See HIVE-16985.
- return null;
+ if (prefixes != null && !prefixes.trim().isEmpty()) {
+ // Currently SMB is broken, so we cannot check if it's compatible
with IO elevator.
Review Comment:
yes, fixed on latest commit.
If you can retry the CI/CD pipeline it will be great.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
