nastra commented on code in PR #7412: URL: https://github.com/apache/iceberg/pull/7412#discussion_r1262401578
########## gcp/src/test/java/org/apache/iceberg/gcp/biglake/BigLakeCatalogTest.java: ########## @@ -0,0 +1,385 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.gcp.biglake; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertThrows; +import static org.junit.Assert.assertTrue; +import static org.mockito.Mockito.any; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +import com.google.api.gax.core.NoCredentialsProvider; +import com.google.api.gax.grpc.testing.LocalChannelProvider; +import com.google.api.gax.grpc.testing.MockGrpcService; +import com.google.api.gax.grpc.testing.MockServiceHelper; +import com.google.cloud.bigquery.biglake.v1.Catalog; +import com.google.cloud.bigquery.biglake.v1.CatalogName; +import com.google.cloud.bigquery.biglake.v1.Database; +import com.google.cloud.bigquery.biglake.v1.DatabaseName; +import com.google.cloud.bigquery.biglake.v1.HiveDatabaseOptions; +import com.google.cloud.bigquery.biglake.v1.MetastoreServiceSettings; +import java.io.File; +import java.nio.file.Path; +import java.util.Arrays; +import java.util.List; +import java.util.UUID; +import org.apache.hadoop.conf.Configuration; +import org.apache.iceberg.CatalogProperties; +import org.apache.iceberg.catalog.CatalogTests; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.exceptions.NoSuchNamespaceException; +import org.apache.iceberg.gcp.GCPProperties; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; +import org.junit.Rule; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; +import org.mockito.junit.MockitoJUnit; +import org.mockito.junit.MockitoRule; + +public class BigLakeCatalogTest extends CatalogTests<BigLakeCatalog> { + + @Rule public final MockitoRule mockito = MockitoJUnit.rule(); + @TempDir public Path temp; + + private static final String GCP_PROJECT = "my-project"; + private static final String GCP_REGION = "us"; + private static final String CATALOG_ID = "biglake"; + + private String warehouseLocation; + + // For tests using a BigLake catalog connecting to a mocked service. + private MockMetastoreService mockMetastoreService; + private MockServiceHelper mockServiceHelper; + private LocalChannelProvider channelProvider; + private BigLakeCatalog bigLakeCatalogUsingMockService; + + // For tests using a BigLake catalog with a mocked client. + private BigLakeClient mockBigLakeClient; + private BigLakeCatalog bigLakeCatalogUsingMockClient; + + @BeforeEach + public void before() throws Exception { + mockMetastoreService = new MockMetastoreService(); + mockServiceHelper = + new MockServiceHelper( + UUID.randomUUID().toString(), Arrays.<MockGrpcService>asList(mockMetastoreService)); + mockServiceHelper.start(); + + File warehouse = temp.toFile(); + warehouseLocation = warehouse.getAbsolutePath(); + + ImmutableMap<String, String> properties = + ImmutableMap.of( + GCPProperties.BIGLAKE_PROJECT_ID, + GCP_PROJECT, + CatalogProperties.WAREHOUSE_LOCATION, + warehouseLocation); + + channelProvider = mockServiceHelper.createChannelProvider(); + MetastoreServiceSettings settings = + MetastoreServiceSettings.newBuilder() + .setTransportChannelProvider(channelProvider) + .setCredentialsProvider(NoCredentialsProvider.create()) + .build(); + + bigLakeCatalogUsingMockService = new BigLakeCatalog(); + bigLakeCatalogUsingMockService.setConf(new Configuration()); + bigLakeCatalogUsingMockService.initialize( + CATALOG_ID, + properties, + GCP_PROJECT, + GCP_REGION, + new BigLakeClient(settings, GCP_PROJECT, GCP_REGION)); + + mockBigLakeClient = mock(BigLakeClient.class); + bigLakeCatalogUsingMockClient = new BigLakeCatalog(); + bigLakeCatalogUsingMockClient.setConf(new Configuration()); + bigLakeCatalogUsingMockClient.initialize( + CATALOG_ID, properties, GCP_PROJECT, GCP_REGION, mockBigLakeClient); + } + + @AfterEach + public void after() { + mockServiceHelper.stop(); + } + + @Override + protected boolean requiresNamespaceCreate() { + return true; + } + + @Override + protected BigLakeCatalog catalog() { + return bigLakeCatalogUsingMockService; + } + + @Override + protected boolean supportsNamesWithSlashes() { + return false; + } + + @Test + public void testDefaultWarehouseWithDatabaseLocation_asExpected() { + when(mockBigLakeClient.getDatabase(DatabaseName.of(GCP_PROJECT, GCP_REGION, CATALOG_ID, "db"))) + .thenReturn( + Database.newBuilder() + .setHiveOptions(HiveDatabaseOptions.newBuilder().setLocationUri("db_folder")) + .build()); + + assertEquals( + "db_folder/table", + bigLakeCatalogUsingMockClient.defaultWarehouseLocation(TableIdentifier.of("db", "table"))); + } + + @Test + public void testDefaultWarehouseWithoutDatabaseLocation_asExpected() { + when(mockBigLakeClient.getDatabase(DatabaseName.of(GCP_PROJECT, "us", CATALOG_ID, "db"))) + .thenReturn( + Database.newBuilder().setHiveOptions(HiveDatabaseOptions.getDefaultInstance()).build()); + + assertEquals( + warehouseLocation + "/db.db/table", + bigLakeCatalogUsingMockClient.defaultWarehouseLocation(TableIdentifier.of("db", "table"))); + } + + @Test + public void testRenameTable_differentDatabase_fail() { + Exception exception = + assertThrows( + IllegalArgumentException.class, + () -> + bigLakeCatalogUsingMockClient.renameTable( + TableIdentifier.of("db0", "t1"), TableIdentifier.of("db1", "t2"))); + assertEquals( + "Cannot rename table db0.t1 to db1.t2: database must match", exception.getMessage()); + } + + @Test + public void testCreateNamespace_createCatalogWhenEmptyNamespace() throws Exception { Review Comment: there seem to be still a few left, like `testDefaultWarehouseWithDatabaseLocation_asExpected` and some others -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
