rdblue commented on code in PR #7873:
URL: https://github.com/apache/iceberg/pull/7873#discussion_r1263138482
##########
python/pyiceberg/utils/datetime.py:
##########
@@ -67,6 +67,11 @@ def time_to_micros(time_str: str) -> int:
return (((t.hour * 60 + t.minute) * 60) + t.second) * 1_000_000 +
t.microsecond
+def time_object_to_micros(t: time) -> int:
Review Comment:
Looks like we did a poor job naming the `time_to_micros` function because
the other similar ones are `date_str_to_days` so this would be
`time_str_to_micros`.
It would be nice to fix this by adding both types to `time_to_micros` and
adding a `time_str_to_micros` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
