coufon commented on code in PR #7412:
URL: https://github.com/apache/iceberg/pull/7412#discussion_r1264604475
##########
build.gradle:
##########
@@ -608,18 +608,42 @@ project(':iceberg-gcp') {
implementation platform('com.google.cloud:libraries-bom')
implementation 'com.google.cloud:google-cloud-storage'
-
- testImplementation 'com.google.cloud:google-cloud-nio'
+ implementation 'com.google.cloud:google-cloud-biglake'
+ compileOnly('org.apache.hadoop:hadoop-common') {
+ exclude group: 'org.apache.avro', module: 'avro'
+ exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ exclude group: 'javax.servlet', module: 'servlet-api'
+ exclude group: 'com.google.code.gson', module: 'gson'
+ }
+ compileOnly("org.apache.hive:hive-metastore") {
Review Comment:
Nice catch, thanks. The internal version uses it to implement Hive Metastore
federation
(https://cloud.google.com/bigquery/docs/manage-open-source-metadata#copy-iceberg-table),
I forgot to clean it up. Removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
