linyanghao commented on code in PR #7628:
URL: https://github.com/apache/iceberg/pull/7628#discussion_r1264717731
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -472,11 +482,16 @@ public void alterTable(ObjectPath tablePath,
CatalogBaseTable newTable, boolean
CatalogTable table = toCatalogTable(icebergTable);
- // Currently, Flink SQL only support altering table properties.
+ // This alterTable API only supports altering table properties.
- // For current Flink Catalog API, support for adding/removing/renaming
columns cannot be done by
+ // Support for adding/removing/renaming columns cannot be done by
// comparing
// CatalogTable instances, unless the Flink schema contains Iceberg column
IDs.
+
+ // To alter columns, use the other alterTable API and provide a list of
TableChange's.
+ LOG.warn(
Review Comment:
The user calling this method will pass a CatalogBaseTable argument, which
represents how the
user expect the table should be like after altering it. So I think it's
better to warn the user, that the schema part of the CatalogBaseTable argument
won't be effective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
