ConeyLiu commented on code in PR #8023:
URL: https://github.com/apache/iceberg/pull/8023#discussion_r1266130321
##########
spark/v3.1/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala:
##########
@@ -255,18 +253,20 @@ case object IcebergParseErrorListener extends
BaseErrorListener {
}
/**
- * Copied from Apache Spark
- * A [[ParseException]] is an [[AnalysisException]] that is thrown during the
parse process. It
- * contains fields and an extended error message that make reporting and
diagnosing errors easier.
+ * Copied from Apache Spark A [[ParseException]] is an [[AnalysisException]]
that is thrown during
Review Comment:
Fixed
##########
spark/v3.1/spark-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/MergeIntoExec.scala:
##########
@@ -87,19 +89,21 @@ case class MergeIntoExec(
val notMatchedPreds = params.notMatchedConditions.map(generatePredicate(_,
joinedAttrs))
val notMatchedProjs =
params.notMatchedOutputs.map(_.map(generateProjection(_, joinedAttrs)))
val projectTargetCols = generateProjection(params.targetOutput,
joinedAttrs)
- val nonMatchedPairs = notMatchedPreds zip notMatchedProjs
+ val nonMatchedPairs = notMatchedPreds zip notMatchedProjs
val matchedPairs = matchedPreds zip matchedProjs
/**
* This method is responsible for processing a input row to emit the
resultant row with an
- * additional column that indicates whether the row is going to be
included in the final
- * output of merge or not.
- * 1. If there is a target row for which there is no corresponding source
row (join condition not met)
- * - Only project the target columns with deleted flag set to false.
- * 2. If there is a source row for which there is no corresponding target
row (join condition not met)
- * - Apply the not matched actions (i.e INSERT actions) if non match
conditions are met.
- * 3. If there is a source row for which there is a corresponding target
row (join condition met)
- * - Apply the matched actions (i.e DELETE or UPDATE actions) if match
conditions are met.
+ * additional column that indicates whether the row is going to be
included in the final output
+ * of merge or not.
+ * 1. If there is a target row for which there is no corresponding
source row (join condition
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
