dramaticlly commented on code in PR #8070:
URL: https://github.com/apache/iceberg/pull/8070#discussion_r1267114279
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFiles.java:
##########
@@ -192,15 +192,15 @@ public void testNullTransform() throws Exception {
testDanglingDelete(2);
}
- private <T> void testDanglingDelete() throws Exception {
+ private void testDanglingDelete() throws Exception {
testDanglingDelete(NUM_DATA_FILES);
}
- private <T> void testDanglingDelete(int numDataFiles) throws Exception {
+ private void testDanglingDelete(int numDataFiles) throws Exception {
Table table = Spark3Util.loadIcebergTable(spark, tableName);
List<DataFile> dataFiles = dataFiles(table);
- Assert.assertEquals(numDataFiles, dataFiles.size());
+ assertThat(numDataFiles).isEqualTo(dataFiles.size());
Review Comment:
nit, can probably use `assertThat(numDataFiles).hasSize(dataFiles.size())`
as well for asserting on size of iterable (doing nullcheck as well internally)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
