liurenjie1024 commented on issue #2: URL: https://github.com/apache/iceberg-rust/issues/2#issuecomment-1645238672
Personally, I prefer the `Serialize`/`Deserialize` approach. From my experience, the effort doesn't reduce much since both way you need to maintain the conversion logic. The `on_disk` approach has some shorting comings: 1. It's not easy to be comptaible with both v1 and v2 spec. See [this pr](https://github.com/icelake-io/icelake/pull/104), I have to remove v1 support since avro has strict schema check. 2. Sometimes we still need to write the serializaer, see https://github.com/liurenjie1024/icelake/blob/eee3520f993837f4e1745c60538ba7ab1b421481/src/types/in_memory.rs#L64 https://github.com/icelake-io/icelake/blob/eee3520f993837f4e1745c60538ba7ab1b421481/src/types/in_memory.rs#L64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
