liurenjie1024 commented on issue #3: URL: https://github.com/apache/iceberg-rust/issues/3#issuecomment-1645244183
I agree the reading/writing part, but has little concern about the api. Still the `summary` example(optional in v1, required in v2), what's the return type of `Snapshot::summary()`? 1. Just `Summary` struct. Then what should be the value filled for v1 format? 2. `Option<Summary>`. Then we have to force user to unwrap it when using v2 format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
