Fokko commented on code in PR #7: URL: https://github.com/apache/iceberg-rust/pull/7#discussion_r1271254879
########## CONTRIBUTING.md: ########## @@ -0,0 +1,95 @@ +# Contributing + +First, thank you for contributing to Iceberg Rust! The goal of this document is to provide everything you need to start contributing to iceberg-rust. The following TOC is sorted progressively, starting with the basics and expanding into more specifics. + +- [Your First Contribution](#your-first-contribution) +- [Workflow](#workflow) + - [Git Branches](#git-branches) + - [GitHub Pull Requests](#github-pull-requests) + - [Title](#title) + - [Reviews & Approvals](#reviews--approvals) + - [Merge Style](#merge-style) + - [CI](#ci) +- [Setup](#setup) + - [Using a dev container environment](#using-a-dev-container-environment) + - [Bring your own toolbox](#bring-your-own-toolbox) +- [Code of Conduct](#code-of-conduct) + +## Your First Contribution + +1. Ensure your change has an issue! Find an [existing issue](https://github.com/apache/iceberg-rust/issues) or [open a new issue](https://github.com/apache/iceberg-rust/issues/new). Review Comment: For me, it feels redundant to have a mandatory issue for each of the PRs. Do we want to make this a hard requirement? ########## CHANGELOG.md: ########## @@ -0,0 +1,8 @@ +# Change Log Review Comment: It is up to the individual projects, what they prefer. What I do with PyIceberg is use the GitHub milestones to keep track of what's being included in a version. You can link both issues and PRs to the milestone, and that works well for me. ########## NOTICE: ########## @@ -0,0 +1,5 @@ +Apache Iceberg Review Comment: Yes, I think that would be best -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
