nastra commented on code in PR #7694:
URL: https://github.com/apache/iceberg/pull/7694#discussion_r1271812978
##########
build.gradle:
##########
@@ -298,12 +289,12 @@ project(':iceberg-api') {
dependencies {
implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
- compileOnly "com.google.errorprone:error_prone_annotations"
- compileOnly "com.google.code.findbugs:jsr305"
- annotationProcessor "org.immutables:value"
- compileOnly "org.immutables:value"
- testImplementation "org.apache.avro:avro"
- testImplementation "com.esotericsoftware:kryo"
+ compileOnly libs.errorprone.annotations
+ compileOnly(libs.findbugs.jsr305)
Review Comment:
nit: we can remove the () here
##########
build.gradle:
##########
@@ -344,33 +335,33 @@ project(':iceberg-core') {
api project(':iceberg-api')
implementation project(':iceberg-common')
implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
- annotationProcessor "org.immutables:value"
- compileOnly "org.immutables:value"
+ annotationProcessor libs.immutables.value
+ compileOnly libs.immutables.value
- implementation("org.apache.avro:avro") {
+ implementation(libs.avro.avro) {
exclude group: 'org.tukaani' // xz compression is not supported
}
- implementation 'io.airlift:aircompressor'
- implementation 'org.apache.httpcomponents.client5:httpclient5'
- implementation "com.fasterxml.jackson.core:jackson-databind"
+ implementation libs.aircompressor
+ implementation libs.httpcomponents.httpclient5
+ implementation platform(libs.jackson.bom)
Review Comment:
shouldn't this keep the `implementation
"com.fasterxml.jackson.core:jackson-databind"` dependency here then?
##########
gradle/libs.versions.toml:
##########
@@ -0,0 +1,153 @@
+# Also see settings.gradle file for dynamic versionCatalogs dependencies
+
+[versions]
+antlr = "4.9.3"
+deltaStandalone = "0.6.0"
+deltaCore = "2.2.0"
+flink115 = { strictly = "[1.15, 1.16[", prefer = "1.15.0"}
+flink116 = { strictly = "[1.16, 1.17[", prefer = "1.16.2"}
+flink117 = { strictly = "[1.17, 1.18[", prefer = "1.17.1"}
Review Comment:
So it seems dependabot indeed needs the rich version as can be seen in
https://github.com/nastra/iceberg/pull/98, as otherwise dependabot will try to
align all versions. I think we should add a comment to the rich version
definition why it is being done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
