rdblue commented on code in PR #8148: URL: https://github.com/apache/iceberg/pull/8148#discussion_r1274194675
########## docs/branching-and-tagging.md: ########## @@ -61,19 +61,19 @@ via Spark SQL. snapshots will be kept, and the branch reference itself will be retained for 1 week. ```sql -- Create a tag for the first end of week snapshot. Retain the snapshot for a week -ALTER TABLE prod.db.table CREATE TAG 'EOW-01' AS OF VERSION 7 RETAIN 7 DAYS +ALTER TABLE prod.db.table CREATE TAG EOW-01 AS OF VERSION 7 RETAIN 7 DAYS Review Comment: I don't think you can use `-` in an identifier name. Shouldn't this be quoted? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
