szehon-ho commented on PR #8132: URL: https://github.com/apache/iceberg/pull/8132#issuecomment-1650809793
I'll have to take a look at those places. Yea the problem is, I think traditionally we can't rely on reader closing the iterator , much less literable. In Spark for example, we dont return the iterable, and even the iterator does not have any close method. https://github.com/apache/spark/blob/bdeae87067452bb41f4776c4ab444a9d9645fdfc/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala#L110 So hence Iceberg implementing auto-close iterators. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
