nastra commented on PR #7992: URL: https://github.com/apache/iceberg/pull/7992#issuecomment-1651039473
> > Once both PRs are merged, I'll add a follow-up and mention in the docs that @Value.Immutable usage is discouraged on iceberg-api (with a checkstyle rule that enforces it) and will also remove the Immutable dependency > > I think we should disallow it, not just discourage it. A checkstyle rule sounds like the right approach though, so maybe we're saying the same thing. Yes we are saying the same thing here. The goal with the docs part was mainly to describe why `@Value.Immutable` should not be in `iceberg-api` and show 1-2 examples of how to apply `@Value.Immutable` to an API that is defined in `iceberg-api`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
