rdblue commented on a change in pull request #953:
URL: https://github.com/apache/incubator-iceberg/pull/953#discussion_r413994471
##########
File path:
spark/src/test/java/org/apache/iceberg/spark/data/TestSparkOrcReader.java
##########
@@ -60,5 +61,29 @@ protected void writeAndValidate(Schema schema) throws
IOException {
}
Assert.assertFalse("Should not have extra rows", actualRows.hasNext());
}
+
+ // Also write and validate where all rows are the same (repeating)
+ final Iterable<InternalRow> expectedRepeating = Collections.nCopies(100,
expected.iterator().next());
Review comment:
Let's add new test cases instead of appending new validations to old
ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
