nastra commented on code in PR #8154:
URL: https://github.com/apache/iceberg/pull/8154#discussion_r1274761175
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java:
##########
@@ -254,6 +255,11 @@ public void testS3FileIOProperties() {
.containsEntry(
S3FileIOProperties.REMOTE_SIGNING_ENABLED,
String.valueOf(s3FileIOProperties.isRemoteSigningEnabled()));
+
+ Assertions.assertThat(map)
+ .containsEntry(
+ S3FileIOProperties.WRITE_STORAGE_CLASS,
+ StorageClass.INTELLIGENT_TIERING.toString());
Review Comment:
it would be better to just pass a plain string rather than adding a
dependency to `com.adobe.testing.s3mock.dto.StorageClass`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
