aokolnychyi commented on code in PR #8123:
URL: https://github.com/apache/iceberg/pull/8123#discussion_r1275589942
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -267,4 +270,30 @@ public boolean aggregatePushDownEnabled() {
.defaultValue(SparkSQLProperties.AGGREGATE_PUSH_DOWN_ENABLED_DEFAULT)
.parse();
}
+
+ public boolean distributedPlanningEnabled() {
+ return dataPlanningMode() != LOCAL || deletePlanningMode() != LOCAL;
+ }
+
+ public PlanningMode dataPlanningMode() {
+ String modeName =
+ confParser
+ .stringConf()
+ .sessionConf(SparkSQLProperties.PLANNING_MODE)
Review Comment:
Mostly speculative I guess if a query touches multiple tables but we want to
enable that only in one?
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -267,4 +270,30 @@ public boolean aggregatePushDownEnabled() {
.defaultValue(SparkSQLProperties.AGGREGATE_PUSH_DOWN_ENABLED_DEFAULT)
.parse();
}
+
+ public boolean distributedPlanningEnabled() {
+ return dataPlanningMode() != LOCAL || deletePlanningMode() != LOCAL;
+ }
+
+ public PlanningMode dataPlanningMode() {
+ String modeName =
+ confParser
+ .stringConf()
+ .sessionConf(SparkSQLProperties.PLANNING_MODE)
Review Comment:
Mostly speculative I guess if a query touches multiple tables but we want to
override only in one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
