ZENOTME commented on PR #12:
URL: https://github.com/apache/iceberg-rust/pull/12#issuecomment-1652928321
> Agree that it's fine for now, to implement 1 we many need some advanced
data structures such as prefix tree, anyway we can postpone the optimization
later.
+1. And I think maintaining lookup table of full field name from a field id
will cause that renaming of a field will affect multiple place (cmiiw)🤔.
```
struct posistion {
struct a{
b
}
}
struct posistion will maintain full name "posistion.a.b"
struct a will maintain full name "a.b"
```
if b be rename, we also need to rename full name in struct posistion and
struct a.
> Thinking of it, I believe it is fine for now. The nested types are more
applicable to a schema, rather than a StructType (they are similar, both have a
fields object).
But if the full name is only maintained in schema, I guess there is not this
problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
