aokolnychyi commented on code in PR #6335:
URL: https://github.com/apache/iceberg/pull/6335#discussion_r1275766984
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -167,6 +167,29 @@ public static ManifestWriter<DataFile> write(
"Cannot write manifest for table version: " + formatVersion);
}
+ /**
+ * Create a new {@link RollingManifestWriter} for the given format version.
+ *
+ * @param formatVersion a target format version
+ * @param snapshotId a snapshot ID for the manifest entries, or null for an
inherited ID
+ * @param spec a {@link PartitionSpec}
+ * @param io a {@link FileIO}
+ * @param outputFileFactory a {@link ManifestOutputFileFactory} to generate
the manifest output
+ * file
+ * @param targetFileSizeInBytes the target file size for manifest files
+ * @return a rolling manifest writer which could generate multiple manifest
files
+ */
+ public static RollingManifestWriter<DataFile> rollingWrite(
Review Comment:
Are we sure this is the best way to expose rolling writers in general? Have
we considered a single parameterized rolling writer that accepts a factory of
manifest writers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
