aokolnychyi commented on code in PR #7582:
URL: https://github.com/apache/iceberg/pull/7582#discussion_r1276901930
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewritePositionDeleteFilesSparkAction.java:
##########
@@ -133,16 +137,23 @@ public RewritePositionDeleteFiles.Result execute() {
}
private StructLikeMap<List<List<PositionDeletesScanTask>>> planFileGroups() {
- CloseableIterable<PositionDeletesScanTask> fileTasks = planFiles();
+ Table deletesTable =
Review Comment:
Why add it here and why rename `fileTasks`? Don't we have to modify
`planFiles` instead?
```
private CloseableIterable<PositionDeletesScanTask> planFiles() {
Table deletesTable =
MetadataTableUtils.createMetadataTableInstance(table,
MetadataTableType.POSITION_DELETES);
PositionDeletesBatchScan scan = (PositionDeletesBatchScan)
deletesTable.newBatchScan();
return CloseableIterable.transform(
scan.baseTableFilter(filter).ignoreResiduals().planFiles(),
task -> (PositionDeletesScanTask) task);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
