szehon-ho commented on code in PR #8158:
URL: https://github.com/apache/iceberg/pull/8158#discussion_r1276971071
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java:
##########
@@ -291,7 +291,7 @@ public void testSelectNestedValues() throws Exception {
public void testNestedValues() throws Exception {
createNestedTable();
- Row leafDoubleCol = Row.of(53L, 3L, 1L, 1L, 0.0D, 0.0D);
+ Row leafDoubleCol = Row.of(46L, 3L, 1L, 1L, 0.0D, 0.0D);
Review Comment:
@dbtsai , i looked into it. I think we have to put it where we write data
files, but its a bigger change. There's a test helper we use called
FileHelpers.writeDataFile() and we need to change the code to take in map of
properties.
Then,
```
public static DataFile writeDataFile(Table table, OutputFile out,
List<Record> rows, Map<String, String> properties)
throws IOException {
FileFormat format = defaultFormat(table.properties());
GenericAppenderFactory factory = new
GenericAppenderFactory(table.schema());
properties.forEach(factory::set);
```
but its ok to do in separate pr if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
