nastra commented on code in PR #8147:
URL: https://github.com/apache/iceberg/pull/8147#discussion_r1277686234
##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -343,6 +364,11 @@ public Map<String, String> updated() {
public void applyTo(TableMetadata.Builder metadataBuilder) {
metadataBuilder.setProperties(updated);
}
+
+ @Override
+ public void applyTo(ViewMetadata.Builder viewMetadataBuilder) {
+ viewMetadataBuilder.properties(updated);
Review Comment:
right now all the builder methods are named exactly like in the generated
Builder. I'll go ahead and update them to have `setXyz` so that we're in line
with the Builder from `TableMetadata`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
