rdblue commented on code in PR #8032:
URL: https://github.com/apache/iceberg/pull/8032#discussion_r1277805460


##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -131,6 +132,9 @@ private FileIO io(String location) {
     String impl = implFromLocation(location);
     FileIO io = ioInstances.get(impl);
     if (io != null) {
+      if (io instanceof HadoopFileIO && ((HadoopFileIO) io).conf() == null) {

Review Comment:
   This cannot modify the IO when accessing it. The underlying IO should use a 
`SerializableConfiguration` anyway, which is created in `setConf`. Why did you 
need to add this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to