mr-brobot commented on PR #8104:
URL: https://github.com/apache/iceberg/pull/8104#issuecomment-1658478143
Ok, this looks better now @Fokko.
On `master`:
```
$ hyperfine --warmup 1 "python -m scripts.pyiceberg"
Benchmark 1: python -m scripts.pyiceberg
Time (mean ± σ): 7.878 s ± 0.567 s [User: 17.848 s, System: 6.409
s]
Range (min … max): 7.243 s … 8.710 s 10 runs
```
On this branch:
```
$ hyperfine --warmup 1 "python -m scripts.pyiceberg"
Benchmark 1: python -m scripts.pyiceberg
Time (mean ± σ): 7.638 s ± 0.281 s [User: 18.225 s, System: 6.889
s]
Range (min … max): 7.184 s … 8.031 s 10 runs
```
Fixed by moving the `row_counts` update into `_task_to_table`. I think some
workers were getting to the end of that function before the limit was recorded
as satisfied in the main thread, resulting in some unnecessary calls to
`to_requested_schema`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
