rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1279987462
##########
core/src/main/java/org/apache/iceberg/encryption/BaseEncryptedOutputFile.java:
##########
@@ -24,10 +24,19 @@ class BaseEncryptedOutputFile implements
EncryptedOutputFile {
private final OutputFile encryptingOutputFile;
private final EncryptionKeyMetadata keyMetadata;
+ private final OutputFile rawOutputFile;
BaseEncryptedOutputFile(OutputFile encryptingOutputFile,
EncryptionKeyMetadata keyMetadata) {
+ this(encryptingOutputFile, keyMetadata, encryptingOutputFile);
+ }
+
+ BaseEncryptedOutputFile(
+ OutputFile encryptingOutputFile,
+ EncryptionKeyMetadata keyMetadata,
+ OutputFile rawOutputFile) {
Review Comment:
Two output files looks really suspicious to me. Maybe we would want to use a
different implementation of the API to avoid that. Shouldn't this create the
encrypting output file rather than having it passed in? Or is that an artifact
from how the encryption manager works?
The encryption manager we use doesn't have to produce these files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
