holdenk commented on code in PR #7886:
URL: https://github.com/apache/iceberg/pull/7886#discussion_r1280151687
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -359,8 +359,8 @@ private boolean canDeleteUsingMetadata(Expression
deleteExpr) {
}
@Override
- public void deleteWhere(Filter[] filters) {
- Expression deleteExpr = SparkFilters.convert(filters);
+ public void deleteWhere(Predicate[] predicates) {
+ Expression deleteExpr = SparkV2Filters.convert(predicates);
Review Comment:
Gotcha, I think I missed the `this method will be invoked only if {@link
#canDeleteWhere(Predicate[])} returns true.` (I was looking at the Iceberg
trait this extends instead of the upstream source).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
