ggershinsky commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1281598140
##########
core/src/main/java/org/apache/iceberg/encryption/BaseEncryptedOutputFile.java:
##########
@@ -24,10 +24,19 @@ class BaseEncryptedOutputFile implements
EncryptedOutputFile {
private final OutputFile encryptingOutputFile;
private final EncryptionKeyMetadata keyMetadata;
+ private final OutputFile rawOutputFile;
BaseEncryptedOutputFile(OutputFile encryptingOutputFile,
EncryptionKeyMetadata keyMetadata) {
+ this(encryptingOutputFile, keyMetadata, encryptingOutputFile);
+ }
+
+ BaseEncryptedOutputFile(
+ OutputFile encryptingOutputFile,
+ EncryptionKeyMetadata keyMetadata,
+ OutputFile rawOutputFile) {
Review Comment:
> Or is that an artifact from how the encryption manager works?
Correct. This is a result of our previous discussion on encryption manager
and Parquet -
https://github.com/apache/iceberg/pull/6884#discussion_r1155361377
"For native Parquet encryption, I think the EncryptedOutputFile and
EncryptedInputFile classes would need to be able to return the underlying
stream as well, so that encryption can be handled by Parquet."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
