rdblue commented on PR #8113: URL: https://github.com/apache/iceberg/pull/8113#issuecomment-1664138173
I don't think we can merge this. This is modifying the `TIMESTAMP WITH TIME ZONE` reader, not the `TIMESTAMP WITH LOCAL TIME ZONE` reader. I don't think we should change the behavior of that existing type unless it is incorrect, and we should use the type-specific logic. Also, it isn't clear that the zone of the object inspector is the SQL session time zone, or whether there is something in Hive that translates later to the session time zone. There are just a lot of unknowns here that we need to confirm before moving ahead: 1. How do we handle `TIMESTAMP WITH LOCAL TIME ZONE`? Do we need a specific reader for it? 2. What is the behavior with respect to the session time zone of that type? What is responsible for conversion? 3. What is the session time zone? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
