ConeyLiu commented on code in PR #8088:
URL: https://github.com/apache/iceberg/pull/8088#discussion_r1283915521
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##########
@@ -334,5 +335,10 @@ private <T> boolean shouldRead(
return ROWS_MIGHT_MATCH;
}
}
+
+ @Override
+ public <T> Boolean handleNonReference(Bound<T> term) {
+ return ROWS_MIGHT_MATCH;
Review Comment:
@rdblue this is not for constant folding. The transform function such as
`years(ts) = 20` could be pushed to fileformat such as parquet/orc. The default
behavior for those non-reference terms is throwing an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
