liurenjie1024 commented on PR #20: URL: https://github.com/apache/iceberg-rust/pull/20#issuecomment-1665138501
I would suggest two changes to this pr: 1. Create a `PrimitiveValue` type so that we can be type safe when ser/de from bytes. 2. Remove the ser/de implementation for composite types, I think we would need to have data types when implementing them, and we can do it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
