nastra commented on code in PR #8168: URL: https://github.com/apache/iceberg/pull/8168#discussion_r1284296607
########## gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSLocation.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.gcp.gcs; + +import com.google.cloud.storage.BlobId; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * This class represents a fully qualified location in GCS expressed as a URI. This class allows for + * URIs with only a bucket and no path specified, unlike with {@link BlobId#fromGsUtilUri(String)}. + */ +class GCSLocation { + private static final String SCHEME_DELIM = "://"; + private static final String PATH_DELIM = "/"; + private static final String QUERY_DELIM = "\\?"; + private static final String FRAGMENT_DELIM = "#"; + + private static final String EXPECTED_SCHEME = "gs"; + + private final String bucket; + private final String prefix; + + /** + * Creates a new GCSLocation with the form of scheme://bucket/path?query#fragment + * + * @param location fully qualified URI + */ + GCSLocation(String location) { + Preconditions.checkNotNull(location, "Location cannot be null."); Review Comment: ```suggestion Preconditions.checkArgument(location != null, "Invalid location: null"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
