advancedxy commented on code in PR #7109:
URL: https://github.com/apache/iceberg/pull/7109#discussion_r1285164750
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/RowDataFileScanTaskReader.java:
##########
@@ -120,6 +138,9 @@ private CloseableIterable<RowData> newIterable(
}
}
+ if (rowFilter != null) {
+ return CloseableIterable.filter(iter, rowFilter::filter);
+ }
Review Comment:
> can you explain what's the dynamic part and how is it related to the
residual filter?
The feature we are developing needs to add some additional scan filters at
planIcebergSourceSplits phase, the additional scan filter is added to
scanContext, which would be part of `task.residual`.
The additional filter itself is dynamically added.
> if that is the case, it is probably simpler.
Then, if we can just use `task.residual`, do you think we should refactor
this PR to use that? Is it possible to revert the class interface change in
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
