rdblue commented on code in PR #7831: URL: https://github.com/apache/iceberg/pull/7831#discussion_r1285261517
########## python/tests/io/test_pyarrow.py: ########## @@ -16,16 +16,39 @@ # under the License. # pylint: disable=protected-access,unused-argument,redefined-outer-name +import math import os import tempfile -from typing import Any, List, Optional +import uuid +from datetime import ( Review Comment: @Fokko, why are there `datetime` classes here? I think that tests like these should completely avoid Python datetime logic and instead should directly use the internal representations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
