Fokko commented on code in PR #8246:
URL: https://github.com/apache/iceberg/pull/8246#discussion_r1285799831
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/data/TestParquetAvroReader.java:
##########
@@ -84,7 +84,8 @@ public class TestParquetAvroReader {
optional(22, "jumpy", Types.DoubleType.get()),
required(23, "koala", Types.TimeType.get()),
required(24, "couch rope", Types.IntegerType.get())))),
- optional(2, "slide", Types.StringType.get()));
+ optional(2, "slide", Types.StringType.get()),
+ optional(25, "foo", Types.DecimalType.of(7, 5)));
Review Comment:
@ajantha-bhat I'm pretty comfortable with Avro yes. This is an interesting
one. In Avro, both `int`'s and `long`'s have the same zigzag encoding. The
difference between `optional` and `required` is that optional has an integer in
front of the actual value that will indicate if the value is null, or not:
https://github.com/apache/iceberg/blob/master/python/pyiceberg/avro/reader.py#L250-L262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
